-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port analytics to use redux-toolkit #2782
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 247 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
src/types/Redux/analytics.ts
line 19 at r1 (raw file):
state.currentPage = action.payload; }, resetAction: () => defaultState,
This is not called; the extra reducer handles reset. This should be removed.
Code quote:
resetAction: () => defaultState,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @jmgrady)
src/types/Redux/analytics.ts
line 19 at r1 (raw file):
Previously, jmgrady (Jim Grady) wrote…
This is not called; the extra reducer handles reset. This should be removed.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Part of #1953
This change is